[ 
https://issues.apache.org/jira/browse/STORM-1845?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15291672#comment-15291672
 ] 

ASF GitHub Bot commented on STORM-1845:
---------------------------------------

Github user hmcl commented on the pull request:

    https://github.com/apache/storm/pull/1422#issuecomment-220407078
  
    @vesense what is the motivation behind this change? Prior to your proposed 
change, the charset used is the one that is defined by the java system property 
`file.encoding`. If this property is absent  the file encoding used will be 
`UTF-8` in JDK8. 
    
    My understanding is that your proposed change will eliminate the chance to 
customize an arbitrary charset using `file.encoding`. Is this the goal?
    
    If the goal is to set `UTF-8` by default, perhaps once should simply set in 
a configuration file the property `file.encoding=UTF-8`


> use UTF-8 instead of default encoding
> -------------------------------------
>
>                 Key: STORM-1845
>                 URL: https://issues.apache.org/jira/browse/STORM-1845
>             Project: Apache Storm
>          Issue Type: Bug
>          Components: storm-hbase, storm-hdfs, storm-hive, storm-redis
>    Affects Versions: 1.0.1
>            Reporter: Xin Wang
>            Assignee: Xin Wang
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to