Github user ptgoetz commented on the pull request:
https://github.com/apache/storm/pull/1393#issuecomment-220705013
Thanks @moesol I merged this into master, 1.x-branch and 1.0.x-branch.
Note that with 1.0.x-branch this created a conflict, as
`KafkaConfig.minFetchByte` had been introduced to do the same thing as your
`KafkaConfig.fetchMinBytes` variable. These are public variables, so they make
up part of the API.
Since 1.0.1 had already been released with the `minFetchByte` varibable, to
ensure backward compatibility I used the `minFetchByte` variable name across
branches.
While I prefer the variable name you chose, I think it's more important to
ensure backward compatibility. :)
Thanks again!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
