[ 
https://issues.apache.org/jira/browse/STORM-1861?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15297259#comment-15297259
 ] 

ASF GitHub Bot commented on STORM-1861:
---------------------------------------

Github user hmcl commented on a diff in the pull request:

    https://github.com/apache/storm/pull/1441#discussion_r64300845
  
    --- Diff: bin/storm.py ---
    @@ -241,7 +240,6 @@ def jar(jarfile, klass, *args):
                 extrajars=[tmpjar, USER_CONF_DIR, STORM_BIN_DIR],
                 args=args,
                 daemon=False,
    --- End diff --
    
    @revans2 can you please take a look and let us know if there is any special 
reason for this process to be forked? This process being forked affects the 
return code. If there is no reason for this process to be forked, this fix will 
correct the return code. Thanks.


> Storm submit command returns exit code of 0 even when it fails
> --------------------------------------------------------------
>
>                 Key: STORM-1861
>                 URL: https://issues.apache.org/jira/browse/STORM-1861
>             Project: Apache Storm
>          Issue Type: Bug
>          Components: storm-core
>    Affects Versions: 1.0.0
>            Reporter: Raghav Kumar Gautam
>            Priority: Blocker
>             Fix For: 1.0.2
>
>
> When we run the command twice:
> {code}
> /usr/hdp/current/storm-client/bin/storm jar 
> /usr/hdp/current/storm-client/contrib/storm-starter/storm-starter-topologies-1.0.1.2.5.0.0-415.jar
>  org.apache.storm.starter.ExclamationTopology mytopology
> {code}
> The second command failed but the exit code was 0 instead of 1. This is 
> regression.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to