Github user unsleepy22 commented on the pull request:
https://github.com/apache/storm/pull/1445#issuecomment-222297509
@abhishekagarwal87
For your Point 2, after more thoughts, I think it might be a little
difficult to move BaseExecutor into Executor. Before creating the real
executor, we need to init some context in advance i.e., ExecutorData, so that
we know whether we want a SpoutExecutor or BoltExecutor, but if we move this
into Executor as an abstract class, this will be that we are trying to create a
BaseExecutor before we know what to create exactly.
I think it's better to rename Executor class to be ExecutorMaker or
ExecutorUtil or something, what do you think?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
