Github user harshach commented on the issue:
https://github.com/apache/storm/pull/1451
@priyank5485 I overlooked that this code is in external/module we can keep
the classes as it is. My comment regarding getComponentConfiguration as it
looks to be doing bit of logic in KafkaSpout and my suggestion was to move that
code to KafkaUtils and call buildKafkaSpoutComponentConfig and return the
config map . This way spout code looks cleaner and may be
buildKafkaSpoutComponentConfig can be reused for trident.
Go ahead with you commit squashes and you can add me to sponsor list since
its in external module
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
