[
https://issues.apache.org/jira/browse/STORM-1723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15311913#comment-15311913
]
ASF GitHub Bot commented on STORM-1723:
---------------------------------------
Github user harshach commented on a diff in the pull request:
https://github.com/apache/storm/pull/1352#discussion_r65499161
--- Diff: storm-core/src/clj/org/apache/storm/daemon/nimbus.clj ---
@@ -1355,48 +1366,843 @@
(defmethod blob-sync :local [conf nimbus]
nil)
-(defserverfn service-handler [conf inimbus]
- (.prepare inimbus conf (master-inimbus-dir conf))
- (log-message "Starting Nimbus with conf " conf)
- (let [nimbus (nimbus-data conf inimbus)
- blob-store (:blob-store nimbus)
- principal-to-local (AuthUtils/GetPrincipalToLocalPlugin conf)
+(defn extract-cluster-metrics [^ClusterSummary summ]
--- End diff --
since we are doing this in ui isn't it better move it to helpers or utils
and import that here in nimbus
> Introduce ClusterMetricsConsumer
> --------------------------------
>
> Key: STORM-1723
> URL: https://issues.apache.org/jira/browse/STORM-1723
> Project: Apache Storm
> Issue Type: New Feature
> Components: storm-core
> Affects Versions: 2.0.0, 1.0.1
> Reporter: Jungtaek Lim
> Assignee: Jungtaek Lim
>
> NOTE: This issue is already discussed shortly. Please refer
> [here|http://mail-archives.apache.org/mod_mbox/storm-dev/201604.mbox/%3CCAF5108hDCcMKxLXKUYLReOoKkNNdgW2YudweR+mKr=1hlsl...@mail.gmail.com%3E]
> for details.
> This issue focuses to introduce ClusterMetricsConsumer and provide interface
> to let users plugin their consumers.
> ClusterMetricsConsumers will be attached to Nimbus, and leader of Nimbus will
> push cluster related metrics to ClusterMetricsConsumer.
> Requirements of ClusterMetricsConsumer are here:
> - Only leader of Nimbus should publish cluster metrics to consumer.
> - Nimbus shouldn't be affected by crashing or heavy latency on consumer.
> - Consumer should have resilient when crashing or Nimbus should take care of.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
