[ 
https://issues.apache.org/jira/browse/STORM-1755?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15311937#comment-15311937
 ] 

ASF GitHub Bot commented on STORM-1755:
---------------------------------------

Github user abhishekagarwal87 commented on the issue:

    https://github.com/apache/storm/pull/1386
  
    @harshach do you mean to suggest something like following
    ```
    <properties>
             <!-- used by old kafka client -->
             <storm.kafka.version>0.8.2.1</storm.kafka.version>
             <storm.kafka.artifact.id>kafka_2.10</storm.kafka.artifact.id>
              
             <!-- used by new kafka client -->
             <storm.kafka.client.version>0.9.0.1</storm.kafka.client.version>
            
<storm.kafka.client.artifact.id>kafka_2.11</storm.kafka.client.artifact.id>
     </properties>
    ```
    I am fine with this approach. what is the naming convention to be followed? 
(storm.kafka and storm.kafka.client is a bit confusing)


> Revert the kafka client version upgrade in storm-kafka module
> -------------------------------------------------------------
>
>                 Key: STORM-1755
>                 URL: https://issues.apache.org/jira/browse/STORM-1755
>             Project: Apache Storm
>          Issue Type: Improvement
>          Components: storm-kafka
>    Affects Versions: 1.0.1
>            Reporter: Abhishek Agarwal
>            Assignee: Abhishek Agarwal
>             Fix For: 2.0.0, 1.0.2, 1.1.0
>
>
> storm-kafka module does not use any feature of new API. The newer kafka 
> client (0.9.x) is not backward compatible with 0.8.x brokers and upgrading 
> storm-kafka version in topology could break the currently running topologies. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to