Github user kosii commented on a diff in the pull request:

    https://github.com/apache/storm/pull/1453#discussion_r65527974
  
    --- Diff: storm-core/src/jvm/org/apache/storm/Config.java ---
    @@ -1872,6 +1872,13 @@
         @isString
         public static final String TOPOLOGY_BOLTS_TUPLE_TIMESTAMP_FIELD_NAME = 
"topology.bolts.tuple.timestamp.field.name";
     
    +    /**
    +     * Bolt-specific configuration for windowed bolts to specify whether 
late tuples should be emitted on a stream
    +     * called _late, instead of being logged with INFO level.
    +     */
    +    @isBoolean
    +    public static final String TOPOLOGY_BOLTS_EMIT_LATE_TUPLE = 
"topology.bolts.emit.late.tuple";
    --- End diff --
    
    I realized that it was hard to achieve a consistent behavior in the earlier 
implementation, because at the moment of calling `declareOutputFields`, we only 
have access to the component specific parameters, but if the user puts the key 
in the global config but forgets to specify at component level, then the stream 
won't be declared, but in the `execute` method it will still going to try to 
emit messages to the non-existing stream.
    On the other hand in the `initWindowManager` method, I can check whether 
the stream exist, and raise an exception if not. Does it seem okay to you? 
Because in this case I'd also prefer the per component based approach.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to