[
https://issues.apache.org/jira/browse/STORM-1873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15312206#comment-15312206
]
ASF GitHub Bot commented on STORM-1873:
---------------------------------------
Github user kosii commented on a diff in the pull request:
https://github.com/apache/storm/pull/1453#discussion_r65527974
--- Diff: storm-core/src/jvm/org/apache/storm/Config.java ---
@@ -1872,6 +1872,13 @@
@isString
public static final String TOPOLOGY_BOLTS_TUPLE_TIMESTAMP_FIELD_NAME =
"topology.bolts.tuple.timestamp.field.name";
+ /**
+ * Bolt-specific configuration for windowed bolts to specify whether
late tuples should be emitted on a stream
+ * called _late, instead of being logged with INFO level.
+ */
+ @isBoolean
+ public static final String TOPOLOGY_BOLTS_EMIT_LATE_TUPLE =
"topology.bolts.emit.late.tuple";
--- End diff --
I realized that it was hard to achieve a consistent behavior in the earlier
implementation, because at the moment of calling `declareOutputFields`, we only
have access to the component specific parameters, but if the user puts the key
in the global config but forgets to specify at component level, then the stream
won't be declared, but in the `execute` method it will still going to try to
emit messages to the non-existing stream.
On the other hand in the `initWindowManager` method, I can check whether
the stream exist, and raise an exception if not. Does it seem okay to you?
Because in this case I'd also prefer the per component based approach.
> Reemit late tuples in windowed mode
> -----------------------------------
>
> Key: STORM-1873
> URL: https://issues.apache.org/jira/browse/STORM-1873
> Project: Apache Storm
> Issue Type: Improvement
> Components: storm-core
> Reporter: Balazs Kossovics
>
> Currently late tuples are just logged (and acknowledged in the coming 1.0.2),
> but in our use-case it would be desirable to emit them on a different stream
> than the default.
> I implemented a first version, where every windowed bolt are going to have a
> '_late' stream by default, and component-specific parameter
> (Config.TOPOLOGY_BOLTS_EMIT_LATE_TUPLE) the definer of the bolt could turn on
> or off the emission of the late tuples on this stream.
> One could turn on the emission of late tuples with a builder method like this:
> {code:title=MyWindowedBolt.java|borderStyle=solid}
> new MyWindowedBolt()
> .withTimestampField("timestamp")
> .withLateTupleEmission(true)
> .withWindow(
> new BaseWindowedBolt.Duration(1, TimeUnit.MINUTES),
> new BaseWindowedBolt.Duration(1, TimeUnit.SECONDS)
> );
> {code}
> What do you think about it?
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
