Francisco Lopes created STORM-1887:
--------------------------------------

             Summary: Help message for the set_log_level command does not have 
the topology name parameter
                 Key: STORM-1887
                 URL: https://issues.apache.org/jira/browse/STORM-1887
             Project: Apache Storm
          Issue Type: Bug
          Components: storm-core
    Affects Versions: 1.0.1
            Reporter: Francisco Lopes
            Priority: Minor
             Fix For: 1.0.2


The help message for `the set_log_level` command does not have the 
`topology-name` parameter:

```
$ storm help set_log_level

    Dynamically change topology log levels

    Syntax: [storm set_log_level -l [logger name]=[log level][:optional 
timeout] -r [logger name]
    where log level is one of:
        ALL, TRACE, DEBUG, INFO, WARN, ERROR, FATAL, OFF
    and timeout is integer seconds.
(...)
```

If you don't pass a `topology-name` as last parameter, you'll get the following 
error:

```
$ storm set_log_level -l com.myapp=WARN
Running: 
/Library/Java/JavaVirtualMachines/jdk1.8.0_60.jdk/Contents/Home/bin/java 
-client -Ddaemon.name= -Dstorm.options= 
-Dstorm.home=/usr/local/Cellar/storm/1.0.1/libexec 
-Dstorm.log.dir=/usr/local/Cellar/storm/1.0.1/libexec/logs 
-Djava.library.path=/usr/local/lib:/opt/local/lib:/usr/lib -Dstorm.conf.file= 
-cp 
/usr/local/Cellar/storm/1.0.1/libexec/lib/asm-5.0.3.jar:/usr/local/Cellar/storm/1.0.1/libexec/lib/clojure-1.7.0.jar:/usr/local/Cellar/storm/1.0.1/libexec/lib/disruptor-3.3.2.jar:/usr/local/Cellar/storm/1.0.1/libexec/lib/kryo-3.0.3.jar:/usr/local/Cellar/storm/1.0.1/libexec/lib/log4j-api-2.1.jar:/usr/local/Cellar/storm/1.0.1/libexec/lib/log4j-core-2.1.jar:/usr/local/Cellar/storm/1.0.1/libexec/lib/log4j-over-slf4j-1.6.6.jar:/usr/local/Cellar/storm/1.0.1/libexec/lib/log4j-slf4j-impl-2.1.jar:/usr/local/Cellar/storm/1.0.1/libexec/lib/minlog-1.3.0.jar:/usr/local/Cellar/storm/1.0.1/libexec/lib/objenesis-2.1.jar:/usr/local/Cellar/storm/1.0.1/libexec/lib/reflectasm-1.10.1.jar:/usr/local/Cellar/storm/1.0.1/libexec/lib/servlet-api-2.5.jar:/usr/local/Cellar/storm/1.0.1/libexec/lib/slf4j-api-1.7.7.jar:/usr/local/Cellar/storm/1.0.1/libexec/lib/storm-core-1.0.1.jar:/usr/local/Cellar/storm/1.0.1/libexec/lib/storm-rename-hack-1.0.1.jar:/usr/local/Cellar/storm/1.0.1/libexec/conf:/usr/local/Cellar/storm/1.0.1/libexec/bin
 org.apache.storm.command.set_log_level -l com.myapp=WARN
2670 [main] INFO  o.a.s.c.set-log-level - Sent log config 
LogConfig(named_logger_level:{com.myapp=LogLevel(action:UPDATE, 
target_log_level:WARN, reset_log_level_timeout_secs:0)}) for topology
Exception in thread "main" java.lang.IllegalArgumentException: No matching 
field found: IllegalArgumentException for class java.lang.String
    at clojure.lang.Reflector.getInstanceField(Reflector.java:271)
    at clojure.lang.Reflector.invokeNoArgInstanceMember(Reflector.java:315)
    at 
org.apache.storm.command.set_log_level$get_storm_id.invoke(set_log_level.clj:31)
    at 
org.apache.storm.command.set_log_level$_main.doInvoke(set_log_level.clj:75)
    at clojure.lang.RestFn.applyTo(RestFn.java:137)
    at org.apache.storm.command.set_log_level.main(Unknown Source)
(...)

I opened a PR to fix this: https://github.com/apache/storm/pull/1463
```



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to