[
https://issues.apache.org/jira/browse/STORM-1873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15319973#comment-15319973
]
ASF GitHub Bot commented on STORM-1873:
---------------------------------------
Github user satishd commented on a diff in the pull request:
https://github.com/apache/storm/pull/1453#discussion_r66190593
--- Diff:
storm-core/test/jvm/org/apache/storm/topology/WindowedBoltExecutorTest.java ---
@@ -28,19 +28,20 @@
import org.apache.storm.tuple.Tuple;
import org.apache.storm.tuple.TupleImpl;
import org.apache.storm.tuple.Values;
+import org.apache.storm.utils.Time;
import org.apache.storm.windowing.TupleWindow;
import org.apache.storm.windowing.WaterMarkEvent;
+import org.hamcrest.Matcher;
import org.junit.Before;
import org.junit.Test;
+import org.mockito.Matchers;
import org.mockito.Mockito;
-import java.util.ArrayList;
-import java.util.Collections;
-import java.util.HashMap;
-import java.util.List;
-import java.util.Map;
+import java.util.*;
--- End diff --
minor nit: Better not to have wildcard imports.
> Reemit late tuples in windowed mode
> -----------------------------------
>
> Key: STORM-1873
> URL: https://issues.apache.org/jira/browse/STORM-1873
> Project: Apache Storm
> Issue Type: Improvement
> Components: storm-core
> Reporter: Balazs Kossovics
>
> Currently late tuples are just logged (and acknowledged in the coming 1.0.2),
> but in our use-case it would be desirable to emit them on a different stream
> than the default.
> I implemented a first version, where every windowed bolt are going to have a
> '_late' stream by default, and component-specific parameter
> (Config.TOPOLOGY_BOLTS_EMIT_LATE_TUPLE) the definer of the bolt could turn on
> or off the emission of the late tuples on this stream.
> One could turn on the emission of late tuples with a builder method like this:
> {code:title=MyWindowedBolt.java|borderStyle=solid}
> new MyWindowedBolt()
> .withTimestampField("timestamp")
> .withLateTupleEmission(true)
> .withWindow(
> new BaseWindowedBolt.Duration(1, TimeUnit.MINUTES),
> new BaseWindowedBolt.Duration(1, TimeUnit.SECONDS)
> );
> {code}
> What do you think about it?
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
