[
https://issues.apache.org/jira/browse/STORM-1700?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15320899#comment-15320899
]
ASF GitHub Bot commented on STORM-1700:
---------------------------------------
Github user ptgoetz commented on a diff in the pull request:
https://github.com/apache/storm/pull/1325#discussion_r66292249
--- Diff: storm-core/src/clj/org/apache/storm/daemon/common.clj ---
@@ -298,18 +299,21 @@
{[comp-id METRICS-STREAM-ID] :shuffle})
(into {}))
- mk-bolt-spec (fn [class arg p]
+ mk-bolt-spec (fn [class arg p max-retain-metric-tuples whitelist
blacklist]
(thrift/mk-bolt-spec*
inputs
- (org.apache.storm.metric.MetricsConsumerBolt.
class arg)
+ (org.apache.storm.metric.MetricsConsumerBolt.
class arg max-retain-metric-tuples (FilterByMetricName. whitelist blacklist))
--- End diff --
Are MetricsFilters intended to be pluggable, or do we only want to allow
filtering by name?
> Introduce 'whitelist' / 'blacklist' option to MetricsConsumer
> -------------------------------------------------------------
>
> Key: STORM-1700
> URL: https://issues.apache.org/jira/browse/STORM-1700
> Project: Apache Storm
> Issue Type: Sub-task
> Components: storm-core
> Affects Versions: 1.0.0, 2.0.0
> Reporter: Jungtaek Lim
> Assignee: Jungtaek Lim
>
> Storm provides various metrics by default, and so on some external modules
> (storm-kafka).
> When we register MetricsConsumer, MetricsConsumer should handle all of
> metrics. If MetricsConsumer cannot keep up with these metrics, only way to
> keep up is increasing parallelism, which seems limited. Furthermore, some
> users don't want to care about some metrics since unintended metrics will
> fill external storage.
> Though MetricsConsumer itself can filter metrics by name, it would be better
> to support filter by Storm side. It will reduce the redundant works for Storm
> community.
> If we provide filter options, it would be great.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
