Github user ptgoetz commented on a diff in the pull request:
https://github.com/apache/storm/pull/1331#discussion_r66318933
--- Diff:
external/storm-kafka/src/jvm/org/apache/storm/kafka/ExponentialBackoffMsgRetryManager.java
---
@@ -86,15 +94,23 @@ public Long nextFailedMessageToRetry() {
}
@Override
- public boolean shouldRetryMsg(Long offset) {
+ public boolean shouldReEmitMsg(Long offset) {
MessageRetryRecord record = this.records.get(offset);
return record != null &&
this.waiting.contains(record) &&
System.currentTimeMillis() >= record.retryTimeUTC;
--- End diff --
I would be nice to log a WARN message when we are dropping messages so
users have a way of knowing when/why it is happening.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
