Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/1325#discussion_r66344797
--- Diff: storm-core/src/clj/org/apache/storm/daemon/common.clj ---
@@ -298,18 +299,21 @@
{[comp-id METRICS-STREAM-ID] :shuffle})
(into {}))
- mk-bolt-spec (fn [class arg p]
+ mk-bolt-spec (fn [class arg p max-retain-metric-tuples whitelist
blacklist]
(thrift/mk-bolt-spec*
inputs
- (org.apache.storm.metric.MetricsConsumerBolt.
class arg)
+ (org.apache.storm.metric.MetricsConsumerBolt.
class arg max-retain-metric-tuples (FilterByMetricName. whitelist blacklist))
--- End diff --
@ptgoetz
I intended to make it pluggable, but if we just want to allow filtering by
name, pluggable incurs unneeded specifying class name. So flexible vs easy to
use.
I'd like to get opinions on this side, and happy to change when we want to
make it flexible.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
