[ 
https://issues.apache.org/jira/browse/STORM-1897?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

gareth smith updated STORM-1897:
--------------------------------
    Description: 
re-pattern file-path-separator will cause errors in windows...

more specifically 
----
java.util.regex.PatternSyntaxException: Unexpected internal error near index 1
\

----

the "\" character (windows separator) is a reserved one in regex.  

hence the logviewer will not work on a windows machine...

A potential fix could be to define:

(defn file-path-separator-regex []
    (if on-windows?
        (re-pattern "\\\\")
        (re-pattern file-path-separator)))

and use this instead of "re-pattern file-path-separator" in logviewer.clj and 
config.clj



  was:
re-pattern file-path-separator will cause errors in windows...

more specifically 
----
java.util.regex.PatternSyntaxException: Unexpected internal error near index 1
\

----

the "\" character (windows separator) is a reserved one in regex.  

hence the logviewer will not work on a windows machine...

A potential fix could be to define:

(defn file-path-separator-regex []
    (if (on-windows?)
        (re-pattern "\\\\")
        (re-pattern file-path-separator)))

and use this instead of "re-pattern file-path-separator" in logviewer.clj and 
config.clj




> re-pattern file-path-separator problem with windows, breaks logviewer
> ---------------------------------------------------------------------
>
>                 Key: STORM-1897
>                 URL: https://issues.apache.org/jira/browse/STORM-1897
>             Project: Apache Storm
>          Issue Type: Bug
>          Components: storm-core
>    Affects Versions: 1.0.0, 1.0.1, 1.0.2, 1.1.0
>            Reporter: gareth smith
>
> re-pattern file-path-separator will cause errors in windows...
> more specifically 
> ----
> java.util.regex.PatternSyntaxException: Unexpected internal error near index 1
> \
> ----
> the "\" character (windows separator) is a reserved one in regex.  
> hence the logviewer will not work on a windows machine...
> A potential fix could be to define:
> (defn file-path-separator-regex []
>     (if on-windows?
>         (re-pattern "\\\\")
>         (re-pattern file-path-separator)))
> and use this instead of "re-pattern file-path-separator" in logviewer.clj and 
> config.clj



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to