[
https://issues.apache.org/jira/browse/STORM-1881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15324269#comment-15324269
]
ASF GitHub Bot commented on STORM-1881:
---------------------------------------
GitHub user sakanaou opened a pull request:
https://github.com/apache/storm/pull/1480
STORM-1881: Create fat-jar of storm-redis which contains needed dependencies
`storm-redis` was packaged in a way that it was not immediately usable when
put into `extlib` folder. `ClassNotFoundException`s would occur.
Via `maven-shade-plugin` a "fat"-jar is created so all depending code is
packaged in.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/sakanaou/storm redis-shadedjar
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/storm/pull/1480.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1480
----
commit b6f89e7a5f63a59d942ecbc63b7ea6711824946e
Author: Daniel Klessing <[email protected]>
Date: 2016-06-10T10:36:53Z
STORM-1881: Create fat-jar of storm-redis which contains needed dependencies
----
> storm-redis is missing dependant libraries in distribution
> ----------------------------------------------------------
>
> Key: STORM-1881
> URL: https://issues.apache.org/jira/browse/STORM-1881
> Project: Apache Storm
> Issue Type: Bug
> Components: storm-redis
> Affects Versions: 1.0.1
> Reporter: Daniel Klessing
>
> Despite the documentation on
> http://storm.apache.org/releases/1.0.1/State-checkpointing.html it is not
> enough to simply copy {{storm-redis-*.jar}} to {{extlib}} to get the
> {{RedisKeyValueStateProvider}} working. Depending jedis and
> apache-commons-pool2 jars are missing and must be copied by hand to get it
> working. Else one is greeted with exception stack traces like:
> {code}
> Caused by: java.lang.ClassNotFoundException:
> org.apache.commons.pool2.impl.GenericObjectPoolConfig
> {code}
> or
> {code}
> Caused by: java.lang.ClassNotFoundException:
> redis.clients.jedis.JedisPoolConfig
> {code}
> Copying {{commons-pool2-2.4.2.jar}} and {{jedis-2.8.1.jar}} from hand to
> {{extlib}} solves the issue.
> It might be better to create a "fat" jar of {{storm-redis-*.jar}} or provide
> documentation, which libraries have to be made available.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
