[ 
https://issues.apache.org/jira/browse/STORM-1277?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15324436#comment-15324436
 ] 

ASF GitHub Bot commented on STORM-1277:
---------------------------------------

Github user abhishekagarwal87 commented on the issue:

    https://github.com/apache/storm/pull/1445
  
    Hi @unsleepy22 . Going through the code, I still think sendUnanchored and 
sendToEventsLogger should be moved to superclass. ackSpoutMsg/failSpoutMsg 
should move to SpoutExecutor class. 
    
    ExecutorData can be merged with BaseExecutor class since executor data is 
common to both spout and bolt. Once that happens, executor object can be passed 
around e.g. 
    ```
    public SpoutOutputCollectorImpl(ISpout spout, SpoutExecutor executorData....
    ```
    Other than that, translation looks good (done with first pass). 


> port backtype.storm.daemon.executor to java
> -------------------------------------------
>
>                 Key: STORM-1277
>                 URL: https://issues.apache.org/jira/browse/STORM-1277
>             Project: Apache Storm
>          Issue Type: New Feature
>          Components: storm-core
>            Reporter: Robert Joseph Evans
>            Assignee: Cody
>              Labels: java-migration, jstorm-merger
>
> https://github.com/apache/storm/tree/jstorm-import/jstorm-core/src/main/java/com/alibaba/jstorm/task
>  kind of.  Tasks and executors are combined in jstorm.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to