Github user abhishekagarwal87 commented on a diff in the pull request:

    https://github.com/apache/storm/pull/1484#discussion_r66955486
  
    --- Diff: pom.xml ---
    @@ -228,7 +228,7 @@
             
<clojure.math.numeric-tower.version>0.0.1</clojure.math.numeric-tower.version>
             <carbonite.version>1.5.0</carbonite.version>
             <snakeyaml.version>1.11</snakeyaml.version>
    -        <httpclient.version>4.3.3</httpclient.version>
    +        <httpclient.version>4.5</httpclient.version>
    --- End diff --
    
    I am not sure about this change. Is this dependency shaded? There has been 
a discussion recently on updating versions of non-shaded dependencies. 
    https://www.mail-archive.com/[email protected]/msg32949.html
    If it is not shaded, it is better to upgrade the version only for 
storm-opentsdb module


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to