[ 
https://issues.apache.org/jira/browse/STORM-1899?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15329794#comment-15329794
 ] 

ASF GitHub Bot commented on STORM-1899:
---------------------------------------

Github user darionyaphet commented on a diff in the pull request:

    https://github.com/apache/storm/pull/1485#discussion_r67004722
  
    --- Diff: 
external/storm-hbase/src/main/java/org/apache/storm/hbase/bolt/AbstractHBaseBolt.java
 ---
    @@ -73,4 +74,13 @@ public void prepare(Map map, TopologyContext 
topologyContext, OutputCollector co
             hbaseConfMap.put(Config.TOPOLOGY_AUTO_CREDENTIALS, 
map.get(Config.TOPOLOGY_AUTO_CREDENTIALS));
             this.hBaseClient = new HBaseClient(hbaseConfMap, hbConfig, 
tableName);
         }
    +
    +    @Override
    +    public void cleanup() {
    +        try {
    +            hBaseClient.close();
    +        } catch (IOException e) {
    +            LOG.error("HBase Client Close Failed");
    --- End diff --
    
    update and rebased 👍 


> Release HBase connection when topology shutdown
> -----------------------------------------------
>
>                 Key: STORM-1899
>                 URL: https://issues.apache.org/jira/browse/STORM-1899
>             Project: Apache Storm
>          Issue Type: Improvement
>          Components: storm-hbase
>    Affects Versions: 1.0.0, 1.0.1
>            Reporter: darion yaphet
>            Assignee: darion yaphet
>            Priority: Minor
>
> Storm HBase Client release connection when topology shutdown.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to