[
https://issues.apache.org/jira/browse/STORM-1913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15338968#comment-15338968
]
ASF GitHub Bot commented on STORM-1913:
---------------------------------------
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/1500#discussion_r67634689
--- Diff:
storm-core/src/jvm/org/apache/storm/topology/BaseConfigurationDeclarer.java ---
@@ -56,7 +56,11 @@ public T setNumTasks(Number val) {
@Override
public T setMemoryLoad(Number onHeap) {
- return setMemoryLoad(onHeap,
Utils.getDouble(conf.get(Config.TOPOLOGY_COMPONENT_RESOURCES_OFFHEAP_MEMORY_MB)));
+ if (onHeap != null) {
+ onHeap = onHeap.doubleValue();
+ return
addConfiguration(Config.TOPOLOGY_COMPONENT_RESOURCES_ONHEAP_MEMORY_MB, onHeap);
+ }
+ return null;
--- End diff --
Minor: This can be replaced with `setMemoryLoad(onHeap, null)` but I'm OK
to split two methods completely.
> Additions and Improvements for Trident RAS API
> ----------------------------------------------
>
> Key: STORM-1913
> URL: https://issues.apache.org/jira/browse/STORM-1913
> Project: Apache Storm
> Issue Type: Improvement
> Reporter: Kyle Nusbaum
> Assignee: Kyle Nusbaum
>
> Trident's RAS API does not honor the following config values:
> {code}
> topology.component.resources.onheap.memory.mb
> topology.component.resources.offheap.memory.mb
> topology.component.cpu.pcore.percent
> {code}
> Trident does not receive the user's config as part of its builder API, so it
> does not know the value of these. Instead of altering the existing API (we
> want to remain backwards-compatible), add some new methods for dealing with
> this.
> There is also currently no way to set the master coord spouts' resources.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
