Github user dossett commented on the issue:
https://github.com/apache/storm/pull/1462
Are there any functional changes here? I'm all in favor of using standard
java interfaces, but I don't see any benefits of `closeable` being used here.
Possible changes could include:
- Using the try-with-resources idiom now that FileReader is `closeable` [1]
- Concrete classes no longer have to catch their own `IOException`s since
close is declared to throw that [2]
[1] -
https://docs.oracle.com/javase/tutorial/essential/exceptions/tryResourceClose.html
[2] -
https://github.com/darionyaphet/storm/blob/ad74ad10012df6999c94652993bcd66e90db53ff/external/storm-hdfs/src/main/java/org/apache/storm/hdfs/spout/TextFileReader.java#L104
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
