[
https://issues.apache.org/jira/browse/STORM-1872?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15344066#comment-15344066
]
ASF GitHub Bot commented on STORM-1872:
---------------------------------------
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/1455#discussion_r68027394
--- Diff:
external/storm-redis/src/main/java/org/apache/storm/redis/common/container/JedisCommandsInstanceContainer.java
---
@@ -34,4 +36,10 @@
* @param jedisCommands borrowed instance
*/
void returnInstance(JedisCommands jedisCommands);
+
+ /**
+ * Release Jedis Connection
--- End diff --
It should be closing container, not Jedis connection.
> Storm Redis connection release
> -------------------------------
>
> Key: STORM-1872
> URL: https://issues.apache.org/jira/browse/STORM-1872
> Project: Apache Storm
> Issue Type: Bug
> Components: storm-redis
> Affects Versions: 1.0.0, 1.0.1, 0.10.2
> Reporter: darion yaphet
>
> Strom Redis connect should be release when topology shutdown .
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
