Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1515#discussion_r68280266
--- Diff: storm-core/src/jvm/org/apache/storm/topology/TopologyBuilder.java
---
@@ -339,8 +353,13 @@ public SpoutDeclarer setSpout(String id, IRichSpout
spout) throws IllegalArgumen
public SpoutDeclarer setSpout(String id, IRichSpout spout, Number
parallelism_hint) throws IllegalArgumentException {
validateUnusedId(id);
initCommon(id, spout, parallelism_hint);
- _spouts.put(id, spout);
- return new SpoutGetter(id);
+
+ if (_spouts.containsKey(id)) {
+ throw new IllegalArgumentException("Spout " + id + " have
existed");
--- End diff --
Similar here `"duplicate spout id found " + id`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
