[
https://issues.apache.org/jira/browse/STORM-1934?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15354980#comment-15354980
]
ASF GitHub Bot commented on STORM-1934:
---------------------------------------
GitHub user HeartSaVioR opened a pull request:
https://github.com/apache/storm/pull/1529
STORM-1934 Fix race condition between sync-supervisor and sync-processes
* sync-supervisor just downloads new topology code and writes new local
assignment
* shutting down workers and removing topology code is moved to
sync-processes
* sync-processes does all of jobs based on local assignment and allocated
workers
PR for 1.x-branch: #1528
Please note that supervisor is ported to Java, so PR for master and PR for
1.x-branch are having different diff. But concept is same.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/HeartSaVioR/storm STORM-1934
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/storm/pull/1529.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1529
----
commit 816a6cc47e5be505d4857e25a4aa14d2f09cade0
Author: Jungtaek Lim <kabh...@gmail.com>
Date: 2016-06-29T10:06:43Z
STORM-1934 Fix race condition between sync-supervisor and sync-processes
* sync-supervisor just downloads new topology code and writes new local
assignment
* shutting down workers and removing topology code is moved to
sync-processes
* sync-processes does all of jobs based on local assignment and allocated
workers
----
> Race condition between sync-supervisor and sync-processes raises several
> strange issues
> ---------------------------------------------------------------------------------------
>
> Key: STORM-1934
> URL: https://issues.apache.org/jira/browse/STORM-1934
> Project: Apache Storm
> Issue Type: Bug
> Components: storm-core
> Affects Versions: 1.0.0, 2.0.0, 1.0.1
> Reporter: Jungtaek Lim
> Assignee: Jungtaek Lim
> Priority: Critical
>
> There're some strange issues including STORM-1933 and others (which I will
> file an issue soon) which are related to race condition in supervisor.
> As I mentioned to STORM-1933, basically sync-supervisor relies on zk
> assignment, and sync-processes relies on local assignment and local workers
> directory, but in fact sync-supervisor also access local state and take some
> actions which affects sync-processes. And also Satish left the comment to
> STORM-1933 describing other issue related to race condition and idea to fix
> this which is same page on me.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
