[ 
https://issues.apache.org/jira/browse/STORM-1919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15356752#comment-15356752
 ] 

ASF GitHub Bot commented on STORM-1919:
---------------------------------------

Github user abhishekagarwal87 commented on a diff in the pull request:

    https://github.com/apache/storm/pull/1517#discussion_r69093854
  
    --- Diff: 
external/storm-redis/src/test/java/org/apache/storm/redis/topology/WhitelistWordCount.java
 ---
    @@ -0,0 +1,155 @@
    +/**
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + * http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.storm.redis.topology;
    +
    +import org.apache.storm.Config;
    +import org.apache.storm.LocalCluster;
    +import org.apache.storm.StormSubmitter;
    +import org.apache.storm.redis.bolt.RedisFilterBolt;
    +import org.apache.storm.redis.common.config.JedisPoolConfig;
    +import org.apache.storm.redis.common.mapper.RedisDataTypeDescription;
    +import org.apache.storm.redis.common.mapper.RedisFilterMapper;
    +import org.apache.storm.task.OutputCollector;
    +import org.apache.storm.task.TopologyContext;
    +import org.apache.storm.topology.OutputFieldsDeclarer;
    +import org.apache.storm.topology.TopologyBuilder;
    +import org.apache.storm.topology.base.BaseRichBolt;
    +import org.apache.storm.tuple.Fields;
    +import org.apache.storm.tuple.ITuple;
    +import org.apache.storm.tuple.Tuple;
    +import org.slf4j.Logger;
    +import org.slf4j.LoggerFactory;
    +
    +import java.util.Map;
    +import java.util.Random;
    +
    +public class WhitelistWordCount {
    --- End diff --
    
    @HeartSaVioR That's fine with me. I have initiated the discussion. 
    +1 for the PR. 


> Introduce FilterBolt on storm-redis
> -----------------------------------
>
>                 Key: STORM-1919
>                 URL: https://issues.apache.org/jira/browse/STORM-1919
>             Project: Apache Storm
>          Issue Type: New Feature
>          Components: storm-redis
>            Reporter: Jungtaek Lim
>            Assignee: Jungtaek Lim
>
> While discussing about STORM-1880, it would be better to have FilterBolt 
> explicitly instead of letting users set up their lookup mapper to act as 
> filter.
> There's other benefit here: we can use exists / hexists on STRING / HASH 
> datatype instead of retrieving actual value which reduces execution time / 
> latency from Redis side.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to