Github user satishd commented on a diff in the pull request:
https://github.com/apache/storm/pull/1531#discussion_r69145885
--- Diff:
storm-core/src/jvm/org/apache/storm/trident/windowing/WindowTridentProcessor.java
---
@@ -163,11 +163,14 @@ public void finishBatch(ProcessorContext
processorContext) {
Iterable<Object> triggerValues = null;
if (retriedAttempt(batchId)) {
- pendingTriggerIds = (List<Integer>)
windowStore.get(inprocessTriggerKey(batchTxnId));
- for (Integer pendingTriggerId : pendingTriggerIds) {
- triggerKeys.add(triggerKey(pendingTriggerId));
+ Object triggerIds =
windowStore.get(inprocessTriggerKey(batchTxnId));
--- End diff --
@wangperry Can you remove creating one more variable. You need to wrap with
a simple null check like below.
```java
if(pendingTriggerIds != null) {
for (Integer pendingTriggerId : pendingTriggerIds) {
triggerKeys.add(triggerKey(pendingTriggerId));
}
triggerValues = windowStore.get(triggerKeys);
}
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
