Github user arunmahadevan commented on a diff in the pull request:
https://github.com/apache/storm/pull/1470#discussion_r69395738
--- Diff:
external/storm-redis/src/main/java/org/apache/storm/redis/state/RedisKeyValueState.java
---
@@ -60,22 +64,23 @@ public RedisKeyValueState(String namespace) {
}
public RedisKeyValueState(String namespace, JedisPoolConfig
poolConfig) {
- this(namespace, poolConfig, new DefaultStateSerializer<K>(), new
DefaultStateSerializer<V>());
+ this(namespace, poolConfig, new DefaultStateSerializer<K>(), new
DefaultStateSerializer<Optional<V>>());
}
- public RedisKeyValueState(String namespace, JedisPoolConfig
poolConfig, Serializer<K> keySerializer, Serializer<V> valueSerializer) {
+ public RedisKeyValueState(String namespace, JedisPoolConfig
poolConfig, Serializer<K> keySerializer, Serializer<Optional<V>>
valueSerializer) {
--- End diff --
Sounds good. If I understood correctly, the user provided serializer would
be used to serialize the value to bytes which is then wrapped in an
Optional<byte[]> and serialized via the DefaultStateSerializer.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
