Github user abhishekagarwal87 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1507#discussion_r69772245
--- Diff: storm-core/src/jvm/org/apache/storm/utils/Utils.java ---
@@ -2104,6 +2109,17 @@ public String addToClasspathImpl(String classpath,
return StringUtils.join(l, CLASS_PATH_SEPARATOR);
}
+ public String addToClasspathImpl(Collection<String> classpath,
+ Collection<String> paths) {
+ String basePath = StringUtils.join(classpath,
CLASS_PATH_SEPARATOR);
--- End diff --
I think the implementation can be simpler.
```
List<String> allPaths = new ArrayList<>();
allPaths.addAll(classPaths)
allPaths.addAll(paths);
return StringUtils.join(allPaths, CLASS_PATH_SEPARATOR);
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
