[ 
https://issues.apache.org/jira/browse/STORM-1916?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15364867#comment-15364867
 ] 

ASF GitHub Bot commented on STORM-1916:
---------------------------------------

Github user knusbaum commented on a diff in the pull request:

    https://github.com/apache/storm/pull/1507#discussion_r69788000
  
    --- Diff: storm-core/src/jvm/org/apache/storm/Config.java ---
    @@ -1835,6 +1835,21 @@
         public static final String TOPOLOGY_CLASSPATH="topology.classpath";
     
         /**
    +     * Topology-specific classpath for the worker child process. This will 
be *prepended* to
    +     * the usual classpath, meaning it can override the Storm classpath. 
This is for debugging
    +     * purposes, and is disabled by default. To allow topologies to be 
submitted with user-first
    +     * classpaths, set the user.classpath.first.enabled config to true.
    +     */
    +    @isStringOrStringList
    +    public static final String 
TOPOLOGY_CLASSPATH_FIRST="topology.classpath.first";
    --- End diff --
    
    I don't think we want that one. Would `topology.classpath.prefix` or 
`topology.prefix.classpath` be better?
    
    It should be `topology.*` because that's the 'namespace' that all topology 
configs live in.


> Add ability for worker-first classpath
> --------------------------------------
>
>                 Key: STORM-1916
>                 URL: https://issues.apache.org/jira/browse/STORM-1916
>             Project: Apache Storm
>          Issue Type: Improvement
>            Reporter: Kyle Nusbaum
>            Assignee: Kyle Nusbaum
>
> Debugging in multi-tenant environments can be difficult, and having the 
> ability to override the classpath can be helpful. We want a topology config 
> that specifies an overriding classpath for a given topology. This config is 
> disabled by default since users overriding the classpath is dangerous in a 
> multi-tenant environment. The config can be temporarily enabled on Nimbus to 
> allow submission of topologies with overridden classpaths. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to