[
https://issues.apache.org/jira/browse/STORM-1952?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jungtaek Lim updated STORM-1952:
--------------------------------
Description:
It's based on review comment from [~sriharsha].
https://github.com/apache/storm/pull/1528/files#r69152524
Please feel free to change reporter if you would like to.
In supervisor we're removing topology code when assignments for that supervisor
has gone.
But there's valid scenario to need to keep the topology code though assignments
for that supervisor is none, for example, rebalancing.
So it would be better for supervisor to keep topology code until topology has
been killed (and all topology workers assigned to that supervisor are also
killed).
was:
It's based on review comment from [~harsha_ch].
https://github.com/apache/storm/pull/1528/files#r69152524
Please feel free to change reporter if you would like to.
In supervisor we're removing topology code when assignments for that supervisor
has gone.
But there's valid scenario to need to keep the topology code though assignments
for that supervisor is none, for example, rebalancing.
So it would be better for supervisor to keep topology code until topology has
been killed (and all topology workers assigned to that supervisor are also
killed).
> Keeping topology code for supervisor until topology got killed
> --------------------------------------------------------------
>
> Key: STORM-1952
> URL: https://issues.apache.org/jira/browse/STORM-1952
> Project: Apache Storm
> Issue Type: Improvement
> Components: storm-core
> Affects Versions: 1.0.0, 2.0.0, 1.0.1
> Reporter: Jungtaek Lim
>
> It's based on review comment from [~sriharsha].
> https://github.com/apache/storm/pull/1528/files#r69152524
> Please feel free to change reporter if you would like to.
> In supervisor we're removing topology code when assignments for that
> supervisor has gone.
> But there's valid scenario to need to keep the topology code though
> assignments for that supervisor is none, for example, rebalancing.
> So it would be better for supervisor to keep topology code until topology has
> been killed (and all topology workers assigned to that supervisor are also
> killed).
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
