[
https://issues.apache.org/jira/browse/STORM-720?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15369965#comment-15369965
]
ASF GitHub Bot commented on STORM-720:
--------------------------------------
Github user harshach commented on the issue:
https://github.com/apache/storm/pull/476
@knusbaum are we good to merge this?
> Storm.cmd should return ERRORLEVEL before exiting main block
> ------------------------------------------------------------
>
> Key: STORM-720
> URL: https://issues.apache.org/jira/browse/STORM-720
> Project: Apache Storm
> Issue Type: Bug
> Components: storm-core
> Affects Versions: 0.9.3, 0.9.4
> Reporter: Ravi Tandon
> Assignee: Ravi Tandon
> Priority: Trivial
> Fix For: 0.9.3, 0.9.4
>
> Attachments: storm_cmd_exitcode_rev0.patch
>
>
> This JIRA is for a very small PR that I will post soon (attached patch)
> Issue: The Storm.cmd does not exit with an ErrorLevel.
> Impact: Any automation via windows banks on return or exit code from the
> program to determine success.
> When can this occur: Passing wrong arguments (like wrong class name or bad
> topology builder code) to java will result in error and any automation
> program will check on the exit code.
> FYI @ [~harsha_ch] [~shanyu]
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
