Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/1526#discussion_r70263885
--- Diff: storm-core/src/jvm/org/apache/storm/spout/ShellSpout.java ---
@@ -47,6 +50,8 @@
private String[] _command;
private Map<String, String> env = new HashMap<>();
private ShellProcess _process;
+ private volatile boolean _running = true;
+ private volatile Throwable _exception;
--- End diff --
Yes it would be better to fix this. Thanks for pointing out. Fixed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
