[ 
https://issues.apache.org/jira/browse/STORM-1960?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15375172#comment-15375172
 ] 

ASF GitHub Bot commented on STORM-1960:
---------------------------------------

Github user abellina commented on a diff in the pull request:

    https://github.com/apache/storm/pull/1557#discussion_r70642673
  
    --- Diff: storm-core/src/clj/org/apache/storm/ui/helpers.clj ---
    @@ -221,10 +221,7 @@
     (defnk json-response
       [data callback :serialize-fn to-json :status 200 :headers {}]
       {:status status
    -   :headers (merge {"Cache-Control" "no-cache, no-store"
    -                    "Access-Control-Allow-Origin" "*"
    -                    "Access-Control-Allow-Headers" "Content-Type, 
Access-Control-Allow-Headers, Access-Controler-Allow-Origin, X-Requested-By, 
X-Csrf-Token, Authorization, X-Requested-With"}
    -              (if (not-nil? callback) {"Content-Type" 
"application/javascript;charset=utf-8"}
    +   :headers ((if (not-nil? callback) {"Content-Type" 
"application/javascript;charset=utf-8"}
    --- End diff --
    
    The Cache-Control no-cache, no-store is something we want to keep for json 
responses.


> Add CORS support to STORM UI Rest api
> -------------------------------------
>
>                 Key: STORM-1960
>                 URL: https://issues.apache.org/jira/browse/STORM-1960
>             Project: Apache Storm
>          Issue Type: Improvement
>            Reporter: Sriharsha Chintalapani
>            Assignee: Sriharsha Chintalapani
>             Fix For: 2.0.0, 1.1.0
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to