Github user abhishekagarwal87 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1560#discussion_r70786295
--- Diff:
storm-core/src/jvm/org/apache/storm/metric/api/IMetricsConsumer.java ---
@@ -54,6 +54,25 @@ public String toString() {
}
public String name;
public Object value;
+
+ @Override
+ public boolean equals(Object o) {
+ if (this == o) return true;
+ if (!(o instanceof DataPoint)) return false;
+
+ DataPoint dataPoint = (DataPoint) o;
+
+ if (name != null ? !name.equals(dataPoint.name) :
dataPoint.name != null) return false;
--- End diff --
it will be good to have parantheses around individual comparisons e.g.
(name != null) or it can be simplified to StringUtils.equals(name,
dataPoint.name)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
