Github user hmcl commented on a diff in the pull request:

    https://github.com/apache/storm/pull/1482#discussion_r70818175
  
    --- Diff: pom.xml ---
    @@ -258,6 +258,12 @@
             <calcite.version>1.4.0-incubating</calcite.version>
             <jackson.version>2.6.3</jackson.version>
             <maven-surefire.version>2.18.1</maven-surefire.version>
    +
    +        <!-- Kafka version used by old kafka spout code -->
    +        <storm.kafka.version>0.8.2.1</storm.kafka.version>
    +        <storm.kafka.artifact.id>kafka_2.10</storm.kafka.artifact.id>
    +
    +        <!-- kafka version used by new kafka spout code -->
    --- End diff --
    
    @abhishekagarwal87 can the property names be a bit more consistent?
    
    A suggestion would be to prefix the properties used by `storm.kafka.client`.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to