Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/1574
@revans2
I'm not clear on part of your comment,
> The one bug I saw while going through the code is that when we list keys,
we are doing it only from the local storage, not form ZK. If we were doing it
from ZK then when someone asks for all of the keys they would be guaranteed to
get all of the keys, but this patch would do no good. Simply because it would
not have an API to know what is local and what is not local. In the short term
I think this is OK, but long term we need to discuss how we really want all of
this to work in the different failure cases.
I think the one bug you stated is about BlobStore, right? Because
`code-ids` just uses exposed BlobStore API, so underlying mechanism shouldn't
be affected to its behavior. And achieving abstraction for BlobStore, like we
pull a file from HDFS and expect pull will be succeed if there's at least one
replica serving that file, when we use local BlobStore and pull blob which is
not available for this nimbus, it should pull from another nimbus automatically
without waiting for nimbus to next sync up cycle.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
