[
https://issues.apache.org/jira/browse/STORM-1970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15385380#comment-15385380
]
ASF GitHub Bot commented on STORM-1970:
---------------------------------------
Github user vesense commented on a diff in the pull request:
https://github.com/apache/storm/pull/1565#discussion_r71467698
--- Diff:
examples/storm-elasticsearch-examples/src/main/java/org/apache/storm/elasticsearch/common/EsConstants.java
---
@@ -0,0 +1,22 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.storm.elasticsearch.common;
+
+public class EsConstants {
--- End diff --
This is a copy. both unit tests and example use this class. so dose
`EsTestUtil`.
> external project examples refator
> ---------------------------------
>
> Key: STORM-1970
> URL: https://issues.apache.org/jira/browse/STORM-1970
> Project: Apache Storm
> Issue Type: Improvement
> Reporter: Xin Wang
> Assignee: Xin Wang
>
> refactor example projects:
> *storm-elasticsearch
> *storm-hbase
> *storm-hdfs
> *storm-hive
> *storm-jdbc
> *storm-kafka
> *storm-mongodb
> *storm-mqtt
> *storm-opentsdb
> *storm-redis
> *storm-solr
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
