[ 
https://issues.apache.org/jira/browse/STORM-1995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15393769#comment-15393769
 ] 

ASF GitHub Bot commented on STORM-1995:
---------------------------------------

Github user abellina commented on a diff in the pull request:

    https://github.com/apache/storm/pull/1593#discussion_r72246238
  
    --- Diff: storm-core/src/clj/org/apache/storm/daemon/nimbus.clj ---
    @@ -1793,16 +1793,16 @@
             (.mark nimbus:num-downloadChunk-calls)
             (check-authorization! nimbus nil nil "fileDownload")
             (let [downloaders (:downloaders nimbus)
    -              ^BufferFileInputStream is (.get downloaders id)]
    +              ^BufferInputStream is (.get downloaders id)]
    --- End diff --
    
    @HeartSaVioR, in beginFileDownload (just above the impl for downloadChunk) 
the type used for the input stream and put into :downloaders is a 
BufferInputStream, hence the change in downloadChunk.


> downloadChunk in nimbus.clj should close the input stream
> ---------------------------------------------------------
>
>                 Key: STORM-1995
>                 URL: https://issues.apache.org/jira/browse/STORM-1995
>             Project: Apache Storm
>          Issue Type: Bug
>    Affects Versions: 0.10.0, 1.0.0, 2.0.0
>            Reporter: Alessandro Bellina
>            Priority: Minor
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to