Github user harshach commented on a diff in the pull request:
https://github.com/apache/storm/pull/1586#discussion_r72300622
--- Diff:
external/storm-kinesis/src/main/java/org/apache/storm/kinesis/spout/ZkInfo.java
---
@@ -0,0 +1,153 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.storm.kinesis.spout;
+
+import java.io.Serializable;
+
+public class ZkInfo implements Serializable {
+ // comma separated list of zk connect strings to connect to zookeeper
e.g. localhost:2181
+ private final String zkUrl;
+ // zk node under which to commit the sequence number of messages. e.g.
/committed_sequence_numbers
+ private final String zkNode;
+ // zk session timeout in milliseconds
+ private final Integer sessionTimeoutMs;
+ // zk connection timeout in milliseconds
+ private final Integer connectionTimeoutMs;
+ // interval at which to commit offsets to zk in milliseconds
+ private final Long commitIntervalMs;
+ // number of retry attempts for zk
+ private final Integer retryAttempts;
+ // time to sleep between retries in milliseconds
+ private final Integer retryIntervalMs;
+
+ /**
+ * Default constructor that uses defaults for a local setup
+ */
+ public ZkInfo () {
+ this("localhost:2181", "/kinesisOffsets", 20000, 15000, 10000L, 3,
2000);
+ }
+
+ public ZkInfo (String zkUrl, String zkNode, Integer sessionTimeoutMs,
Integer connectionTimeoutMs, Long commitIntervalMs, Integer retryAttempts,
Integer
+ retryIntervalMs) {
+ this.zkUrl = zkUrl;
+ this.zkNode = zkNode;
+ this.sessionTimeoutMs = sessionTimeoutMs;
+ this.connectionTimeoutMs = connectionTimeoutMs;
+ this.commitIntervalMs = commitIntervalMs;
+ this.retryAttempts = retryAttempts;
+ this.retryIntervalMs = retryIntervalMs;
+ validate();
+ }
+
+ public String getZkUrl() {
+ return zkUrl;
+ }
+
+ public String getZkNode() {
+ return zkNode;
+ }
+
+ public Integer getSessionTimeoutMs() {
+ return sessionTimeoutMs;
+ }
+
+ public Integer getConnectionTimeoutMs() {
+ return connectionTimeoutMs;
+ }
+
+ public Long getCommitIntervalMs() {
+ return commitIntervalMs;
+ }
+
+ public Integer getRetryAttempts() {
+ return retryAttempts;
+ }
+
+ public Integer getRetryIntervalMs() {
+ return retryIntervalMs;
+ }
+
+ private void validate () {
+
+ if (zkUrl == null || zkUrl.length() < 1) {
+ throw new IllegalArgumentException("zkUrl must be specified to
connect to zookeeper");
+ }
+ if (zkNode == null || zkNode.length() < 1) {
+ throw new IllegalArgumentException("zkNode must be specified");
+ }
+ checkPositive(sessionTimeoutMs, "sessionTimeoutMs");
+ checkPositive(connectionTimeoutMs, "connectionTimeoutMs");
+ checkPositive(commitIntervalMs, "commitIntervalMs");
+ checkPositive(retryAttempts, "retryAttempts");
+ checkPositive(retryIntervalMs, "retryIntervalMs");
+ }
+
+ private void checkPositive (Integer argument, String name) {
+ if (argument == null && argument <= 0) {
+ throw new IllegalArgumentException(name + " must be positive");
+ }
+ }
+ private void checkPositive (Long argument, String name) {
+ if (argument == null && argument <= 0) {
+ throw new IllegalArgumentException(name + " must be positive");
+ }
+ }
+
+ @Override
+ public String toString() {
+ return "ZkInfo{" +
+ "zkUrl='" + zkUrl + '\'' +
+ ", zkNode='" + zkNode + '\'' +
+ ", sessionTimeoutMs=" + sessionTimeoutMs +
+ ", connectionTimeoutMs=" + connectionTimeoutMs +
+ ", commitIntervalMs=" + commitIntervalMs +
+ ", retryAttempts=" + retryAttempts +
+ ", retryIntervalMs=" + retryIntervalMs +
+ '}';
+ }
+
+ @Override
--- End diff --
remove these as well.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
