Github user hmcl commented on the issue:

    https://github.com/apache/storm/pull/1587
  
    @darionyaphet this kafka spout does not use zookeeper as the new Kafka API 
writes the offsets to a topic rather than to zookeeper. As I mentioned in the 
initial comment, this change is not necessary. Furthermore, all the kafka 
properties are supposed to go in a map, as illustrated in  [this 
example](https://github.com/apache/storm/blob/master/external/storm-kafka-client/src/test/java/org/apache/storm/kafka/spout/test/KafkaSpoutTopologyMainNamedTopics.java#L115-L123)
    
    At last, the commitTimer is not used in auto commit mode. 
    
    I would like to suggest that you close this PR.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to