Github user abhishekagarwal87 commented on a diff in the pull request:

    https://github.com/apache/storm/pull/1598#discussion_r72606243
  
    --- Diff: storm-core/src/jvm/org/apache/storm/command/Heartbeats.java ---
    @@ -0,0 +1,65 @@
    +package org.apache.storm.command;
    +
    +import com.google.common.base.Joiner;
    +import org.apache.storm.cluster.ClusterStateContext;
    +import org.apache.storm.cluster.ClusterUtils;
    +import org.apache.storm.cluster.IStateStorage;
    +import org.apache.storm.generated.ClusterWorkerHeartbeat;
    +import org.apache.storm.stats.StatsUtil;
    +import org.apache.storm.utils.ConfigUtils;
    +import org.apache.storm.utils.Utils;
    +import org.json.simple.JSONValue;
    +import org.slf4j.Logger;
    +import org.slf4j.LoggerFactory;
    +
    +import java.util.Map;
    +
    +public class Heartbeats {
    +    private static final Logger LOG = 
LoggerFactory.getLogger(Heartbeats.class);
    +
    +    public static void main(String[] args) throws Exception {
    +        String command = args[0];
    --- End diff --
    
    should we have a check for length here? ArrayOutOfBoundsException may be 
confusing for cli user. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to