[ 
https://issues.apache.org/jira/browse/STORM-1277?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15399181#comment-15399181
 ] 

ASF GitHub Bot commented on STORM-1277:
---------------------------------------

Github user unsleepy22 commented on a diff in the pull request:

    https://github.com/apache/storm/pull/1445#discussion_r72778899
  
    --- Diff: storm-core/src/jvm/org/apache/storm/utils/Utils.java ---
    @@ -2364,4 +2374,23 @@ public static long bitXor(Long a, Long b) {
             return rtn;
         }
     
    +    /**
    +     * converts a clojure PersistentMap to java HashMap
    +     */
    +    public static Map<String, Object> convertMap(Map map) {
    --- End diff --
    
    Will change method name. For parameter type, this method is called in 
`Executor.mkExecutor` which passes in `Map workerData`, which should later be 
replaced with a normal java map after worker is ported to java, so I personally 
prefer the generic Map type instead of using APersistentMap.


> port backtype.storm.daemon.executor to java
> -------------------------------------------
>
>                 Key: STORM-1277
>                 URL: https://issues.apache.org/jira/browse/STORM-1277
>             Project: Apache Storm
>          Issue Type: New Feature
>          Components: storm-core
>            Reporter: Robert Joseph Evans
>            Assignee: Cody
>              Labels: java-migration, jstorm-merger
>
> https://github.com/apache/storm/tree/jstorm-import/jstorm-core/src/main/java/com/alibaba/jstorm/task
>  kind of.  Tasks and executors are combined in jstorm.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to