Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/1595#discussion_r72866761
--- Diff: storm-core/src/jvm/org/apache/storm/daemon/StormCommon.java ---
@@ -436,7 +414,9 @@ public static void addMetricComponents(Map conf,
StormTopology topology) {
public static void addSystemComponents(Map conf, StormTopology
topology) {
Map<String, StreamInfo> outputStreams = new HashMap<String,
StreamInfo>();
outputStreams.put(Constants.SYSTEM_TICK_STREAM_ID,
Thrift.outputFields(Arrays.asList("rate_secs")));
+ outputStreams.put(Constants.METRICS_STREAM_ID,
Thrift.directOutputFields(Arrays.asList("task-info", "data-points")));
--- End diff --
Oh sorry I've confused. We send the metrics tuple from each task with fake
source stream which is `SYSTEM_TASK_ID METRICS_STREAM_ID`, so it's needed.
Please see the change of `metric-tick`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
