[
https://issues.apache.org/jira/browse/STORM-2006?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15400069#comment-15400069
]
ASF GitHub Bot commented on STORM-2006:
---------------------------------------
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/1595#discussion_r72866761
--- Diff: storm-core/src/jvm/org/apache/storm/daemon/StormCommon.java ---
@@ -436,7 +414,9 @@ public static void addMetricComponents(Map conf,
StormTopology topology) {
public static void addSystemComponents(Map conf, StormTopology
topology) {
Map<String, StreamInfo> outputStreams = new HashMap<String,
StreamInfo>();
outputStreams.put(Constants.SYSTEM_TICK_STREAM_ID,
Thrift.outputFields(Arrays.asList("rate_secs")));
+ outputStreams.put(Constants.METRICS_STREAM_ID,
Thrift.directOutputFields(Arrays.asList("task-info", "data-points")));
--- End diff --
Oh sorry I've confused. We send the metrics tuple from each task with fake
source stream which is `SYSTEM_TASK_ID METRICS_STREAM_ID`, so it's needed.
Please see the change of `metric-tick`.
> Storm metrics feature improvement: support per-worker level metrics
> aggregation
> -------------------------------------------------------------------------------
>
> Key: STORM-2006
> URL: https://issues.apache.org/jira/browse/STORM-2006
> Project: Apache Storm
> Issue Type: Improvement
> Components: storm-core
> Affects Versions: 1.1.0
> Reporter: Jungtaek Lim
> Assignee: Jungtaek Lim
>
> Storm provides per-task level metrics which could be huge when topology has a
> number of tasks.
> Task level metric is useful for determining load balance between tasks, but
> it doesn't need to be time-series fashion.
> Before introducing topology level component like TopologyMaster for JStorm,
> we can utilize SystemBolt to aggregate task level metrics to per-worker level
> metrics.
> We should provide options and this feature should be turned off by default to
> keep backward compatibility.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
