Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/1445#discussion_r72930327
--- Diff:
storm-core/src/jvm/org/apache/storm/executor/spout/SpoutOutputCollectorImpl.java
---
@@ -0,0 +1,147 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.storm.executor.spout;
+
+import org.apache.storm.daemon.Acker;
+import org.apache.storm.daemon.Task;
+import org.apache.storm.executor.TupleInfo;
+import org.apache.storm.spout.ISpout;
+import org.apache.storm.spout.ISpoutOutputCollector;
+import org.apache.storm.tuple.MessageId;
+import org.apache.storm.tuple.TupleImpl;
+import org.apache.storm.tuple.Values;
+import org.apache.storm.utils.MutableLong;
+import org.apache.storm.utils.RotatingMap;
+import org.apache.storm.utils.Utils;
+
+import java.util.ArrayList;
+import java.util.List;
+import java.util.Random;
+
+public class SpoutOutputCollectorImpl implements ISpoutOutputCollector {
+
+ private final SpoutExecutor executor;
+ private final Task taskData;
+ private final int taskId;
+ private final MutableLong emittedCount;
+ private final boolean hasAckers;
+ private final Random random;
+ private final Boolean isEventLoggers;
+ private final Boolean isDebug;
+ private final RotatingMap<Long, TupleInfo> pending;
+
+ @SuppressWarnings("unused")
+ public SpoutOutputCollectorImpl(ISpout spout, SpoutExecutor executor,
Task taskData, int taskId,
+ MutableLong emittedCount, boolean
hasAckers, Random random,
+ Boolean isEventLoggers, Boolean
isDebug, RotatingMap<Long, TupleInfo> pending) {
+ this.executor = executor;
+ this.taskData = taskData;
+ this.taskId = taskId;
+ this.emittedCount = emittedCount;
+ this.hasAckers = hasAckers;
+ this.random = random;
+ this.isEventLoggers = isEventLoggers;
+ this.isDebug = isDebug;
+ this.pending = pending;
+ }
+
+ @Override
+ public List<Integer> emit(String streamId, List<Object> tuple, Object
messageId) {
+ return sendSpoutMsg(streamId, tuple, messageId, null);
+ }
+
+ @Override
+ public void emitDirect(int taskId, String streamId, List<Object>
tuple, Object messageId) {
+ sendSpoutMsg(streamId, tuple, messageId, taskId);
+ }
+
+ @Override
+ public long getPendingCount() {
+ return pending.size();
+ }
+
+ @Override
+ public void reportError(Throwable error) {
+ executor.getReportError().report(error);
+ }
+
+ private List<Integer> sendSpoutMsg(String stream, List<Object> values,
Object messageId, Integer outTaskId) {
+ emittedCount.increment();
+
+ List<Integer> outTasks;
+ if (outTaskId != null) {
+ outTasks = taskData.getOutgoingTasks(outTaskId, stream,
values);
+ } else {
+ outTasks = taskData.getOutgoingTasks(stream, values);
+ }
+
+ List<Long> ackSeq = new ArrayList<>();
+ boolean needAck = (messageId != null) && hasAckers;
+
+ long rootId = MessageId.generateId(random);
+ for (Integer t : outTasks) {
+ MessageId msgId;
+ if (needAck) {
+ long as = MessageId.generateId(random);
+ msgId = MessageId.makeRootId(rootId, as);
+ ackSeq.add(as);
+ } else {
+ msgId = MessageId.makeUnanchored();
+ }
+
+ TupleImpl tuple = new
TupleImpl(executor.getWorkerTopologyContext(), values, this.taskId, stream,
msgId);
+ executor.getExecutorTransfer().transfer(t, tuple);
+ }
+ if (isEventLoggers) {
+ executor.sendToEventLogger(executor, taskData, values,
executor.getComponentId(), messageId, random);
+ }
+
+ boolean sample = false;
+ try {
+ sample = executor.getSampler().call();
+ } catch (Exception ignored) {
+ }
+ if (needAck) {
+ TupleInfo info = new TupleInfo();
+ info.setTaskId(this.taskId);
+ info.setStream(stream);
+ info.setMessageId(messageId);
+ if (isDebug) {
+ info.setValues(values);
+ }
+ if (sample) {
+ info.setTimestamp(System.currentTimeMillis());
+ }
+
+ pending.put(rootId, info);
+ List<Object> ackInitTuple = new Values(rootId,
Utils.bitXorVals(ackSeq), this.taskId);
+ executor.sendUnanchored(taskData, Acker.ACKER_INIT_STREAM_ID,
ackInitTuple, executor.getExecutorTransfer());
+ } else if (messageId != null) {
+ TupleInfo info = new TupleInfo();
+ info.setStream(stream);
+ info.setValues(values);
+ info.setMessageId(messageId);
+ info.setTimestamp(0);
+ Long timeDelta = sample ? 0L : null;
+ info.setId("0:");
+ executor.ackSpoutMsg(executor, taskData, timeDelta, info);
+ }
+
+ return outTasks;
--- End diff --
Does it ensure that at least empty list is returned?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
