[ 
https://issues.apache.org/jira/browse/STORM-1979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15407867#comment-15407867
 ] 

ASF GitHub Bot commented on STORM-1979:
---------------------------------------

Github user omkreddy commented on a diff in the pull request:

    https://github.com/apache/storm/pull/1583#discussion_r73535370
  
    --- Diff: 
external/storm-druid/src/main/java/org/apache/storm/druid/trident/DruidBeamState.java
 ---
    @@ -0,0 +1,73 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + * http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing,
    + * software distributed under the License is distributed on an
    + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
    + * KIND, either express or implied.  See the License for the
    + * specific language governing permissions and limitations
    + * under the License.
    + */
    +package org.apache.storm.druid.trident;
    +
    +import com.metamx.tranquility.beam.Beam;
    +import com.twitter.util.Await;
    +import org.apache.storm.trident.state.State;
    +import org.slf4j.Logger;
    +import org.slf4j.LoggerFactory;
    +import scala.collection.JavaConversions;
    +
    +import java.util.List;
    +
    +
    +/**
    + * Trident {@link State} implementation for Druid.
    + */
    +public class DruidBeamState<E> implements State  {
    +    private static final Logger LOG = 
LoggerFactory.getLogger(DruidBeamState.class);
    +
    +    Beam<E> beam = null;
    +
    +    public DruidBeamState(Beam<E> beam) {
    +        this.beam = beam;
    +    }
    +
    +    public void send(List<E> events ) {
    +        try {
    +            LOG.info("Sending %d events", events.size());
    +            
Await.result(beam.sendBatch(JavaConversions.collectionAsScalaIterable(events).toList()));
    +        } catch (Exception e) {
    +            final String errorMsg = "Failed in writing messages to Druid";
    +            LOG.error(errorMsg, e);
    +            throw new RuntimeException(errorMsg);
    +        }
    +    }
    +
    +    public void close() {
    +        try {
    +            Await.result(beam.close());
    +        } catch (Exception e) {
    +            final String errorMsg = "Error while closing Druid beam 
client";
    +            LOG.error(errorMsg, e);
    +            throw new RuntimeException(errorMsg);
    +        }
    +    }
    +
    +    @Override
    +    public void beginCommit(Long txid) {
    --- End diff --
    
    Druid Tranquility library itself  does not support exactly-once semantics 
and it is not key-value store. 


> Storm Druid Connector
> ---------------------
>
>                 Key: STORM-1979
>                 URL: https://issues.apache.org/jira/browse/STORM-1979
>             Project: Apache Storm
>          Issue Type: Improvement
>            Reporter: Sriharsha Chintalapani
>            Assignee: Manikumar Reddy
>
> Storm Bolt & Trident state implementation for Druid.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to