[
https://issues.apache.org/jira/browse/STORM-2020?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15408026#comment-15408026
]
ASF GitHub Bot commented on STORM-2020:
---------------------------------------
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/1606#discussion_r73553509
--- Diff:
external/storm-hdfs/src/test/java/org/apache/storm/hdfs/spout/TestHdfsSpout.java
---
@@ -704,12 +703,12 @@ public MockCollector() {
@Override
public void emitDirect(int arg0, String arg1, List<Object> arg2,
Object arg3) {
- throw new NotImplementedException();
+ throw new RuntimeException("NOT Implemented");
--- End diff --
I prefer using UnsupportedOperationException in this case but since it's
just a test code I'm OK.
> Stop using sun internal classes
> -------------------------------
>
> Key: STORM-2020
> URL: https://issues.apache.org/jira/browse/STORM-2020
> Project: Apache Storm
> Issue Type: Bug
> Components: storm-hdfs, storm-redis
> Affects Versions: 2.0.0
> Reporter: Robert Joseph Evans
> Assignee: Robert Joseph Evans
>
> sun.reflect.generics.reflectiveObjects.NotImplementedException,
> sun.misc.BASE64Decoder, and sun.misc.BASE64Encoder are not public APIs we
> should not be using them.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
