[ 
https://issues.apache.org/jira/browse/STORM-1993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15409244#comment-15409244
 ] 

ASF GitHub Bot commented on STORM-1993:
---------------------------------------

Github user HeartSaVioR commented on a diff in the pull request:

    https://github.com/apache/storm/pull/1581#discussion_r73668059
  
    --- Diff: external/sql/README.md ---
    @@ -70,17 +70,31 @@ To run this example, users need to include the data 
sources (`storm-sql-kafka` i
     class path. One approach is to put the required jars into the `extlib` 
directory:
     
     ```
    -$ cp curator-client-2.5.0.jar curator-framework-2.5.0.jar 
zookeeper-3.4.6.jar
    - extlib/
    -$ cp scala-library-2.10.4.jar kafka-clients-0.8.2.1.jar 
kafka_2.10-0.8.2.1.jar metrics-core-2.2.0.jar extlib/
    -$ cp json-simple-1.1.1.jar extlib/
    -$ cp storm-kafka-*.jar storm-sql-kafka-*.jar storm-sql-runtime-*.jar 
extlib/
    +calcite-avatica-1.4.0-incubating.jar
    --- End diff --
    
    @manuzhang 
    Please refer 
https://github.com/apache/storm/pull/1608#issuecomment-237807425
    Once we merge STORM-2016 we can get rid of needs for copying dependencies 
to extlib. When STORM-2023 is merged, running `storm sql` will be much simpler.


> Update storm-sql README to have actual dependencies
> ---------------------------------------------------
>
>                 Key: STORM-1993
>                 URL: https://issues.apache.org/jira/browse/STORM-1993
>             Project: Apache Storm
>          Issue Type: Documentation
>          Components: storm-sql
>            Reporter: Jungtaek Lim
>            Assignee: Jungtaek Lim
>
> http://storm.apache.org/releases/1.0.1/storm-sql.html
> In order to run storm-sql-kafka example, the document states that users need 
> to copy these jar files to extlib:
> curator-client-2.5.0.jar, curator-framework-2.5.0.jar, zookeeper-3.4.6.jar, 
> scala-library-2.10.4.jar, kafka-clients-0.8.2.1.jar, kafka_2.10-0.8.2.1.jar, 
> metrics-core-2.2.0.jar, json-simple-1.1.1.jar, 
> jackson-annotations-2.6.0.jar,storm-kafka-\*.jar 
> storm-sql-kafka-\*.jar,storm-sql-runtime-\*.jar
> But in fact this is not enough to run the example from Storm 1.0.2 RC3.
> I need to copy below things to extlib to make workers running properly.
> {code}
> calcite-avatica-1.4.0-incubating.jar
> calcite-core-1.4.0-incubating.jar
> calcite-linq4j-1.4.0-incubating.jar
> commons-lang-2.6.jar
> curator-client-2.5.0.jar
> curator-framework-2.5.0.jar
> guava-16.0.1.jar
> jackson-annotations-2.6.0.jar
> jackson-core-2.6.3.jar
> jackson-databind-2.6.3.jar
> json-simple-1.1.1.jar
> kafka-clients-0.8.2.1.jar
> kafka_2.10-0.8.2.1.jar
> metrics-core-2.2.0.jar
> scala-library-2.10.4.jar
> storm-kafka-1.0.2.jar
> storm-sql-kafka-1.0.2.jar
> storm-sql-runtime-1.0.2.jar
> zookeeper-3.4.6.jar
> {code}
> While I feel storm-sql also needs to provide uber jar with shaded 
> dependencies (since copying them to extlib affects worker classpath which 
> breaks user topologies) guide document should be updated to run the example 
> properly.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to