[
https://issues.apache.org/jira/browse/STORM-2016?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15411537#comment-15411537
]
ASF GitHub Bot commented on STORM-2016:
---------------------------------------
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/1608#discussion_r73842378
--- Diff: storm-core/src/jvm/org/apache/storm/generated/Assignment.java ---
@@ -787,15 +787,15 @@ public void read(org.apache.thrift.protocol.TProtocol
iprot, Assignment struct)
case 2: // NODE_HOST
if (schemeField.type == org.apache.thrift.protocol.TType.MAP) {
{
- org.apache.thrift.protocol.TMap _map548 =
iprot.readMapBegin();
- struct.node_host = new
HashMap<String,String>(2*_map548.size);
- String _key549;
- String _val550;
- for (int _i551 = 0; _i551 < _map548.size; ++_i551)
+ org.apache.thrift.protocol.TMap _map564 =
iprot.readMapBegin();
--- End diff --
There's no dumb question. This is just a one of practices on Storm project.
As always there're some pros and cons regarding this:
pros: Thrift compiler is only needed for contributors who modifies
storm.thrift, and the case is actually not often.
cons: Thrift generates codes which makes huge diff even though just adding
only one field.
IMO, installing thrift compiler because of just build project is bad,
especially OSPs are using different versions of thrift. While disadvantage is
also not a trivial, I think advantage is valuable enough.
> Topology submission improvement: support adding local jars and maven
> artifacts on submission
> --------------------------------------------------------------------------------------------
>
> Key: STORM-2016
> URL: https://issues.apache.org/jira/browse/STORM-2016
> Project: Apache Storm
> Issue Type: Improvement
> Components: storm-core
> Reporter: Jungtaek Lim
> Assignee: Jungtaek Lim
>
> This JIRA tracks actual work on below proposal / design document.
> https://cwiki.apache.org/confluence/display/STORM/A.+Design+doc%3A+adding+jars+and+maven+artifacts+at+submission
> Proposal discussion thread is here:
> http://mail-archives.apache.org/mod_mbox/storm-dev/201608.mbox/%3ccaf5108i9+tjanz0lgrktmkvqel7f+53k9uyzxct6zhsu6oh...@mail.gmail.com%3E
> Let's post on discussion thread if we have any opinions / ideas on this
> instead of leaving comments on this issue.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
