[
https://issues.apache.org/jira/browse/STORM-2023?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15411989#comment-15411989
]
ASF GitHub Bot commented on STORM-2023:
---------------------------------------
Github user harshach commented on a diff in the pull request:
https://github.com/apache/storm/pull/1610#discussion_r73901017
--- Diff: storm-dist/binary/src/main/assembly/binary.xml ---
@@ -305,12 +305,13 @@
</includes>
</fileSet>
<fileSet>
-
<directory>${project.basedir}/../../external/sql/storm-sql-runtime/target</directory>
+
<directory>${project.basedir}/../../external/sql/storm-sql-runtime/target/appassembler/repo</directory>
--- End diff --
can we call appassembler to app-assembler. single word making it confusing.
> Add calcite-core to dependency of storm-sql-runtime
> ---------------------------------------------------
>
> Key: STORM-2023
> URL: https://issues.apache.org/jira/browse/STORM-2023
> Project: Apache Storm
> Issue Type: Bug
> Components: storm-sql
> Affects Versions: 1.0.0
> Reporter: Jungtaek Lim
> Assignee: Jungtaek Lim
>
> storm-sql provides both "storm-sql-core" and "storm-sql-runtime". Former is
> for compiling sql to trident topology, and latter is for running compiled
> trident topology.
> While testing storm-sql feature I found compiled class codes refers calcite
> so calcite-core is needed at runtime.
> I'm not sure we can make calcite-core get out of storm-sql-runtime, so for
> now we can add calcite-core to storm-sql-runtime so that it can be available
> on transitive dependencies for storm-sql-runtime.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
